Skip to content

Conversation

itsarijitray
Copy link
Contributor

@itsarijitray itsarijitray commented Jun 25, 2025

Handling errors that are not originated from braze side (request-client errors)

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link

codecov bot commented Jun 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.02%. Comparing base (7c45464) to head (bbd3232).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../src/destinations/braze/upsertCatalogItem/utils.ts 0.00% 0 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3025   +/-   ##
=======================================
  Coverage   78.02%   78.02%           
=======================================
  Files        1109     1109           
  Lines       20588    20588           
  Branches     3981     3981           
=======================================
  Hits        16063    16063           
+ Misses       3165     3164    -1     
- Partials     1360     1361    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@itsarijitray itsarijitray marked this pull request as ready for review June 25, 2025 09:42
@itsarijitray itsarijitray requested a review from a team as a code owner June 25, 2025 09:42
@itsarijitray itsarijitray merged commit b177719 into main Jun 26, 2025
13 of 14 checks passed
@itsarijitray itsarijitray deleted the patch/STRATCONN-5861 branch June 26, 2025 05:35
kc-ong-taguchi pushed a commit to kc-ong-taguchi/action-destinations that referenced this pull request Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants