Updated to latest firebase analytics for destination #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prayansh
reviewed
Jul 23, 2021
Comment on lines
106
to
109
| var bundledProperties: Bundle? | ||
| payload.properties.let { | ||
| val formattedProperties = formatProperties(it) | ||
| firebaseAnalytics.logEvent(eventName, formattedProperties) | ||
| analytics.log("firebaseAnalytics.logEvent($eventName, $formattedProperties)") | ||
| bundledProperties = formatProperties(it) | ||
| } |
There was a problem hiding this comment.
more idiomatic to write
val bundledProperties = payload.properties?.let {
formatProperties(it)
}
prayansh
requested changes
Jul 23, 2021
There was a problem hiding this comment.
Lets also add the logic to replace the forbidden characters with _ instead of filtering them out here. https://github.com/segmentio/analytics-kotlin/pull/17/files#diff-eb2eec385880c84c9b2512d6b31654185e07bd923c4544014e1bb0a94d37f7d8R223-R227
prayansh
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to the newest version which had some deprecations around screen tracking. Also fixed an issue with track method skipping if properties weren't included.