Locale Timestamp #170
Merged
Locale Timestamp #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisdeng2002
commented
Jun 5, 2023
| val sdf = SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss'.'Szzz") | ||
| // Note, we should specify locale = Locale.ROOT, otherwise the timestamp returned will use | ||
| // the default locale, which may not be what we want. | ||
| val sdf = SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss'.'Szzz", Locale.ROOT) |
There was a problem hiding this comment.
The Android docs recommend using Locale.US, but since this might be used in JVM projects I opted to go with Locale.ROOT
The default locale is not appropriate for machine-readable output. The best choice there is usually Locale.US – this locale is guaranteed to be available on all devices, and the fact that it has no surprising special cases and is frequently used (especially for computer-computer communication) means that it tends to be the most efficient choice too.
wenxi-zeng
approved these changes
Jun 5, 2023
wenxi-zeng
reviewed
Jun 5, 2023
| @Test | ||
| fun `dateTimeNowString() produces a string in the correct format`() { | ||
| val dateTimeNowString = dateTimeNowString() | ||
| val regex = Regex("^[0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:\\d{2}\\.\\d{3}Z$") |
There was a problem hiding this comment.
this regex fails unit test. try this one "^\\d{4}-[0-1][0-3]-[0-3]\\d{1}T[0-2]\\d{1}:[0-5]\\d{1}:[0-5]\\d{1}Z$"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Android, if you set the app language to
Arabicthe timestamp will be formatted using the device locale, i.e.٠٥T١٠:٤٨:٢٩.٥Z. I've attached screenshots of the behavior before / after the changesBefore / After (Arabic)
Before / After (English)