Skip to content

Adding PassiveLocationPlugin to the Kotlin sample app. #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

didiergarcia
Copy link
Contributor

This plugin add location information to the event.context.location property if the host app is granted location access. If the host app is not granted location access the event.context.location property is set to "n/a".

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5376cc7) 78.40% compared to head (0ac8bab) 78.40%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #188   +/-   ##
=========================================
  Coverage     78.40%   78.40%           
  Complexity      492      492           
=========================================
  Files            78       78           
  Lines          6502     6502           
  Branches        821      821           
=========================================
  Hits           5098     5098           
  Misses          740      740           
  Partials        664      664           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


override fun execute(event: BaseEvent): BaseEvent? {

event.context = buildJsonObject {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use updateJsonObject to avoid writing line 23-25 out

@didiergarcia didiergarcia merged commit 3107561 into main Oct 25, 2023
@didiergarcia didiergarcia deleted the add-passive-location-plugin-sample branch October 25, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants