Skip to content

SegmentDestination refactor and add cdnHost config option #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 9, 2021
Merged

SegmentDestination refactor and add cdnHost config option #34

merged 4 commits into from
Sep 9, 2021

Conversation

prayansh
Copy link
Contributor

@prayansh prayansh commented Sep 8, 2021 •
edited
Loading

Summary of changes

  • General code cleanup
  • Add new config option cdnHost enabling users to modify from where settings are fetched
  • Refactor Segment destination to new template format

@prayansh prayansh requested a review from wenxi-zeng September 8, 2021 21:44
wenxi-zeng
wenxi-zeng approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@wenxi-zeng wenxi-zeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. can you also add a builder function to ConfigurationBuilder for cdnHost?

@prayansh
Copy link
Contributor Author

prayansh commented Sep 8, 2021

good call. will add that

@prayansh prayansh merged commit 1e57a32 into main Sep 9, 2021
@prayansh prayansh deleted the pray/segment-refactor branch September 9, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenxi-zeng wenxi-zeng wenxi-zeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prayansh @wenxi-zeng