keep dispatcher and scope config internal #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenxi-zeng
changed the title
prayansh
reviewed
Sep 13, 2021
| @@ -364,7 +345,7 @@ class AndroidLifecyclePluginTests { | |||
| // Simulate activity startup | |||
| lifecyclePlugin.onActivityCreated(mockActivity, mockBundle) | |||
|
|
|||
| assertTrue(mockPlugin.ran) | |||
| verify (timeout = 2000){ mockPlugin.updateState(true) } | |||
There was a problem hiding this comment.
is this timeout necessary due to us not being able to run the tests with the testDispatcher?
There was a problem hiding this comment.
correct. because we are not able to use testDispatcher, things running async. there is a delay before the update happen. the verify waits until the statement happened or timeout reached, whichever one comes first.
prayansh
approved these changes
Sep 13, 2021
| internal var ioDispatcher: CoroutineDispatcher = Executors.newFixedThreadPool(1) | ||
| .asCoroutineDispatcher() | ||
|
|
||
| internal var analyticsScope: CoroutineScope = MainScope() |
There was a problem hiding this comment.
lets make this CoroutineScope(SupervisorJob()) rather than using the main scope
There was a problem hiding this comment.
agree. I was also worried about it running in main thread. changing it now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Configurationconstructors, keep them internalAdditional Changes