Add disable API boolean #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f3979c9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
silesky
force-pushed
the
add-disabled-option
branch
from
5600222
to
ec1c63e
Compare
silesky
force-pushed
the
add-disabled-option
branch
from
1aebdc1
to
6a23d0b
Compare
silesky
force-pushed
the
add-disabled-option
branch
from
6a23d0b
to
71219b4
Compare
silesky
force-pushed
the
add-disabled-option
branch
from
c150979
to
f5ee410
Compare
silesky
force-pushed
the
add-disabled-option
branch
from
f5ee410
to
f3979c9
Compare
oscb
approved these changes
Nov 16, 2023
Comment on lines
+31
to
+36
| it('integration: should not touch cookies or localStorage', async () => { | ||
| const analytics = new NullAnalytics() | ||
| await analytics.track('foo') | ||
| const storage = getAjsBrowserStorage() | ||
| expect(Object.values(storage).every((v) => !v)).toBe(true) | ||
| }) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs: segmentio/segment-docs#5681
Add 'disable' boolean / function option to allow for disabling Segment in a testing environment, which will allow us to disable segment.