Skip to content

Conversation

bsneed
Copy link
Contributor

@bsneed bsneed commented Sep 17, 2021

  • Added example of automatic notification tracking for iOS/tvOS/watchOS.
  • Fixed incorrect method signatures in iOS lifecycle plugin.

@@ -22,7 +22,7 @@ class AppDelegate: NSObject, NSApplicationDelegate {
.flushInterval(10)

analytics = Analytics(configuration: configuration)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe add a comment: // Uncomment to add notification tracking to your app or something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a placeholder until I get full lifecycle stuff on Mac working.

@@ -10,6 +10,8 @@
import Foundation
import UIKit

// NOTE: These method signatures are marked optional as application extensions may not have
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Copy link
Contributor

@migs647 migs647 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsneed bsneed merged commit d28a2c9 into main Sep 17, 2021
@bsneed bsneed deleted the bsneed/notification_tracking branch September 17, 2021 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants