Skip to content

Fixes issue w/ amplitude sessionId not working #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

bsneed
Copy link
Contributor

@bsneed bsneed commented Sep 21, 2021

When we changed the application param to be optional for app extensions, this one was missed, so it's falling back to the default implementation that does nothing.

Copy link
Contributor

@migs647 migs647 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dannyhertz
Copy link

LGTM :)

@bsneed bsneed merged commit 71b653a into main Sep 23, 2021
@bsneed bsneed deleted the bsneed/lifecycle_fixes branch September 23, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants