Skip to content
This repository was archived by the owner on Sep 3, 2022. It is now read-only.

Conversation

juliofarah
Copy link
Contributor

@juliofarah juliofarah commented Jul 20, 2020

Description

This PR adds types to most of the functions and variables in analytics.ts. Unfortunately, it is pretty hard to strictly type functions as some of them assume parameters with multiple types (such as function | object | string).

Types added in this PR are still work in progress and must be updated.

bonus:

  • Update PR Template
  • Update CODEOWNERS

Test plan

Testing completed successfully with make watch-e2e on ajs private:
ajs

Release plan

New version is not required because this is still work in progress

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@7c85af7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #166   +/-   ##
=========================================
  Coverage          ?   96.36%           
=========================================
  Files             ?        3           
  Lines             ?       55           
  Branches          ?        0           
=========================================
  Hits              ?       53           
  Misses            ?        2           
  Partials          ?        0           
Impacted Files Coverage Δ
lib/utils/each.js 90.47% <0.00%> (ø)
lib/utils/clone.js 100.00% <0.00%> (ø)
lib/utils/map.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c85af7...0ddda29. Read the comment docs.

@juliofarah juliofarah requested review from nettofarah and a team July 20, 2020 19:31
@juliofarah juliofarah marked this pull request as ready for review July 20, 2020 19:32
@williamgrosset williamgrosset self-requested a review July 20, 2020 19:55
@williamgrosset
Copy link

Will re-review after test plan. Do we want to break these PRs into two? One for updating PR templates and the other for types?

@juliofarah juliofarah changed the title Types/libweb 260 Introduce types to ajs core Jul 20, 2020
@juliofarah
Copy link
Contributor Author

Will re-review after test plan. Do we want to break these PRs into two? One for updating PR templates and the other for types?

@williamgrosset nah I think it's fine to keep both in the same PR
PR template is one of those things we just do small tweaks from time to time, no need to create a new PR for it

@juliofarah juliofarah requested a review from pooyaj July 20, 2020 21:02
Copy link
Contributor

@danieljackins danieljackins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@juliofarah juliofarah merged commit 0644fe2 into master Jul 20, 2020
@juliofarah juliofarah deleted the types/libweb-260 branch July 20, 2020 21:13
@juliofarah juliofarah mentioned this pull request Jul 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants