-
Notifications
You must be signed in to change notification settings - Fork 85
Introduce types to ajs core #166
Conversation
Codecov Report
@@ Coverage Diff @@
## master #166 +/- ##
=========================================
Coverage ? 96.36%
=========================================
Files ? 3
Lines ? 55
Branches ? 0
=========================================
Hits ? 53
Misses ? 2
Partials ? 0
Continue to review full report at Codecov.
|
Will re-review after test plan. Do we want to break these PRs into two? One for updating PR templates and the other for types? |
@williamgrosset nah I think it's fine to keep both in the same PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
Description
This PR adds types to most of the functions and variables in
analytics.ts
. Unfortunately, it is pretty hard to strictly type functions as some of them assume parameters with multiple types (such asfunction | object | string
).Types added in this PR are still work in progress and must be updated.
bonus:
Test plan
Testing completed successfully with

make watch-e2e
on ajs private:Release plan
New version is not required because this is still work in progress