Skip to content
This repository was archived by the owner on Sep 3, 2022. It is now read-only.

Conversation

juliofarah
Copy link
Contributor

@juliofarah juliofarah commented Jul 27, 2020

Description

This PR

  • Move user.js to user.ts
  • Splits index.d.ts into two files (now global-modules.d.ts including jQuery and Zeptos definitions and global.d.ts including AnalyticsJs definitions)
  • Removes private fields from Analytics.JS

Test plan

  • Testing completed successfully make test-e2e and make watch-e2e:
    ajscore

Release plan

New version is not required because this is a dev-only change

@juliofarah juliofarah changed the title Types/libweb 260 [Types] Move user.js to user.ts Jul 27, 2020
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@344b9bc). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #172   +/-   ##
=========================================
  Coverage          ?   96.36%           
=========================================
  Files             ?        3           
  Lines             ?       55           
  Branches          ?        0           
=========================================
  Hits              ?       53           
  Misses            ?        2           
  Partials          ?        0           
Impacted Files Coverage Δ
lib/utils/each.js 90.47% <0.00%> (ø)
lib/utils/map.js 100.00% <0.00%> (ø)
lib/utils/clone.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 344b9bc...c5e98c2. Read the comment docs.

@juliofarah juliofarah marked this pull request as ready for review July 27, 2020 22:47
@juliofarah juliofarah requested a review from a team July 27, 2020 22:53
@juliofarah juliofarah merged commit aa59e80 into master Jul 28, 2020
@juliofarah juliofarah deleted the types/libweb-260 branch July 28, 2020 16:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants