Skip to content
This repository was archived by the owner on Sep 3, 2022. It is now read-only.

Conversation

juliofarah
Copy link
Contributor

Description

This PR exposes analytics.js-core types so users can leverage them.

Test plan

  • Testing completed successfully by importing ajs-core's npm dependency into a new repo and using its types:
    types

Release plan

@juliofarah juliofarah requested a review from a team July 28, 2020 23:25
Copy link
Contributor

@pooyaj pooyaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm so far 👍

"author": "Segment <friends@segment.com>",
"version": "3.13.6",
"description": "The hassle-free way to integrate analytics into any web application.",
"types": "lib/index.d.ts",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@juliofarah juliofarah marked this pull request as ready for review July 29, 2020 16:45
@juliofarah juliofarah merged commit d52c5e4 into master Jul 29, 2020
@juliofarah juliofarah deleted the readme/LIBWEB-326 branch July 29, 2020 16:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants