Skip to content
This repository was archived by the owner on Sep 3, 2022. It is now read-only.

Conversation

Dahaden
Copy link
Contributor

@Dahaden Dahaden commented Jul 29, 2020

Description

Noticed some APIs have get and set functionality bu the typescript types didnt reflect this.

Soooo happy to see updated being made to this repo and especially the adoption of typescript!! Thank you so much!

Test plan

  • Testing completed successfully by @juliofarah using internal tools and e2e tests:
    dahaden
    image

-->

Release plan

New version is not required because this is a dev-only change

@Dahaden
Copy link
Contributor Author

Dahaden commented Jul 29, 2020

Also, If you have any time, this is something that we have found causes a few issues with us on some clients :(
segmentio/localstorage-retry#17

@juliofarah
Copy link
Contributor

@Dahaden thank you so much for opening this PR! I'm so happy to see this. One of the biggest reasons why started the Typescript migration was to enable contributions like this!

I'm going to spend a few minutes testing your changes end to end with a few other internal services we have and, if everything looks fine, I'll merge it right away.

Thanks again for your contribution

@juliofarah juliofarah self-requested a review July 29, 2020 17:30
Copy link
Contributor

@juliofarah juliofarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Dahaden
I have pulled this branch locally and tested against some internal tools - and took the liberty of updating the PR description with screenshots taken from those tests.

We really appreciate your contribution, looking forward to seeing more of these 🏅

@juliofarah juliofarah merged commit c706745 into segmentio:master Jul 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants