Skip to content
This repository was archived by the owner on Sep 3, 2022. It is now read-only.

Conversation

bryanmikaelian
Copy link
Contributor

@bryanmikaelian bryanmikaelian commented Aug 20, 2020

Description

This PR removes the library @ndhoule/foldr in favor of the function Array.prototype.reduce

Test plan

Testing completed successfully by verifying existing unit tests pass

Checklist

  • Thorough explanation of the issue/solution, and a link to the related issue
  • CI tests are passing
  • Unit tests were written for any new code
  • Code coverage is at least maintained, or increased.

@bryanmikaelian bryanmikaelian force-pushed the bryan/replace-with-native-functions-foldl branch 2 times, most recently from ea8f779 to 066dff8 Compare August 20, 2020 17:06
@bryanmikaelian bryanmikaelian changed the title Replace foldl with Array.prototype.reduce Replace @ndhoule/foldl with Array.prototype.reduce Aug 20, 2020
@bryanmikaelian bryanmikaelian marked this pull request as ready for review August 20, 2020 17:36
@bryanmikaelian bryanmikaelian force-pushed the bryan/replace-with-native-functions-foldl branch from 066dff8 to 1dd090f Compare September 1, 2020 17:39
@bryanmikaelian bryanmikaelian requested a review from a team September 1, 2020 17:41
@codecov-commenter
Copy link

Codecov Report

Merging #186 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #186   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            3         3           
=========================================
  Hits             3         3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eec02e1...6af89d5. Read the comment docs.

Copy link

@nettofarah nettofarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

@bryanmikaelian bryanmikaelian merged commit 01f29dc into master Sep 1, 2020
@bryanmikaelian bryanmikaelian deleted the bryan/replace-with-native-functions-foldl branch September 1, 2020 18:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants