Skip to content
This repository was archived by the owner on Sep 3, 2022. It is now read-only.

Conversation

bryanmikaelian
Copy link
Contributor

@bryanmikaelian bryanmikaelian commented Aug 26, 2020

Description

This PR bumps Karma and all related plugins to the latest version. We are several versions behind and cannot leverage TypeScript features for our tests. A new version is not needed since this is a dev only change

Test plan

Testing not required because it is a dev-only change

Release plan

New version is not required because it is a dev only change

Checklist

  • Thorough explanation of the issue/solution, and a link to the related issue
  • CI tests are passing
  • Unit tests were written for any new code
  • Code coverage is at least maintained, or increased.

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@ed0a5fa). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #189   +/-   ##
=========================================
  Coverage          ?   96.29%           
=========================================
  Files             ?        3           
  Lines             ?       54           
  Branches          ?        0           
=========================================
  Hits              ?       52           
  Misses            ?        2           
  Partials          ?        0           
Impacted Files Coverage Δ
lib/utils/clone.js 100.00% <0.00%> (ø)
lib/utils/each.js 90.47% <0.00%> (ø)
lib/utils/map.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed0a5fa...563b95c. Read the comment docs.

Copy link
Contributor

@pooyaj pooyaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice 👌👌👌

@bryanmikaelian bryanmikaelian merged commit 9495826 into master Aug 27, 2020
@bryanmikaelian bryanmikaelian deleted the bryan/upgrade-karma branch August 27, 2020 09:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants