Skip to content
This repository was archived by the owner on Sep 3, 2022. It is now read-only.

Conversation

bryanmikaelian
Copy link
Contributor

@bryanmikaelian bryanmikaelian commented Sep 1, 2020

Description

This PR adds a commit hook that blocks adding new JS files.
Screen Shot 2020-09-01 at 1 33 04 PM

Screen Shot 2020-09-01 at 1 29 48 PM

Test plan

  • Testing not required because this is a dev-only change

Release plan

New version is not required because it's a dev-only change

Checklist

  • Thorough explanation of the issue/solution, and a link to the related issue
  • CI tests are passing
  • Unit tests were written for any new code
  • Code coverage is at least maintained, or increased.

@bryanmikaelian bryanmikaelian requested a review from a team September 1, 2020 17:32
Copy link

@nettofarah nettofarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@codecov-commenter
Copy link

Codecov Report

Merging #193 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #193   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            3         3           
=========================================
  Hits             3         3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10f178a...f4f8528. Read the comment docs.

@bryanmikaelian bryanmikaelian merged commit eec02e1 into master Sep 1, 2020
@bryanmikaelian bryanmikaelian deleted the bryan/no-more-js-allowed branch September 1, 2020 17:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants