Skip to content
This repository has been archived by the owner on Sep 3, 2022. It is now read-only.

Upgrade top-domain to 3.0.1 #246

Merged
merged 3 commits into from
Apr 14, 2021
Merged

Upgrade top-domain to 3.0.1 #246

merged 3 commits into from
Apr 14, 2021

Conversation

juliofarah
Copy link
Contributor

@juliofarah juliofarah commented Apr 14, 2021

Description

This PR upgrades top-domain to 3.0.1 to upgrade nested dependencies such as component-cookies, debug and ms that had security vulnerabilities.

Test plan

  • Testing completed successfully locally using analytics.js-core v 4.1.10-beta.0, published to NPM and a local react app.
    image

Release plan

  • Once the beta version is tested, update package.json to remove the beta tag and run npm publish;

@codecov-io
Copy link

codecov-io commented Apr 14, 2021

Codecov Report

Merging #246 (42d57be) into master (06eb832) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #246   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            3         3           
=========================================
  Hits             3         3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06eb832...42d57be. Read the comment docs.

@juliofarah juliofarah marked this pull request as ready for review April 14, 2021 19:30
@juliofarah juliofarah merged commit da69129 into master Apr 14, 2021
@juliofarah juliofarah deleted the top-domain branch April 14, 2021 20:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants