This repository was archived by the owner on Sep 3, 2022. It is now read-only.
setup codecov.io #75
Merged
setup codecov.io #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2prateek
force-pushed
the
coverage
branch
18 times, most recently
from
885c609 to
eb5820e
Compare
Adds a new karma configuration that can generate coverage reports that are uploaded to codecov.io. For some reason, Safari and IE tests fail 100% of the time when code coverage is enabled (likely due to the browserify-istanbul plugin). Rather than skip those browser or skip coverage entirely, I opted to make a new karma configuration that is exclusively used to report coverage results. This runs as a seperate job on CI and runs only on PhantomJS.
|
You can see the reports generated here https://codecov.io/gh/segmentio/analytics.js-core/tree/665649f69397608595b88e539216d5fdf1cc8262. |
|
cc @fathyb |
f2prateek
commented
Jun 20, 2018
| - image: circleci/node:8-browsers | ||
| steps: | ||
| - checkout | ||
| - run: npm config set "//registry.npmjs.org/:_authToken" $NPM_AUTH |
There was a problem hiding this comment.
It would be nice to be able to re-use this from the test job, but I couldn't figure out how.
fathyb
reviewed
Jun 21, 2018
| @@ -0,0 +1,44 @@ | |||
| /* eslint-env node */ | |||
There was a problem hiding this comment.
Why do we need to do the coverage separately? Can't we run test with coverage enabled and then collect coverage data? RTFD 🤦♂️
f2prateek
added a commit
to segment-integrations/analytics.js-integration-segmentio
that referenced
this pull request
Jun 12, 2019
This updates a variety of tooling we use to build and releaase the library, such as: * Update to circle ci v2 as v1 is deprecated * Use commitlint and commitizen to maintain clean commit history * Update Karma configuration so we can use it with codecov to report coverage (see segmentio/analytics.js-core#75 for notes on implementation) * Use np to simplify the releasing process
f2prateek
added a commit
to segment-integrations/analytics.js-integration-segmentio
that referenced
this pull request
Jun 12, 2019
This updates a variety of tooling we use to build and releaase the library, such as: * Update to circle ci v2 as v1 is deprecated * Use commitlint and commitizen to maintain clean commit history * Update Karma configuration so we can use it with codecov to report coverage (see segmentio/analytics.js-core#75 for notes on implementation) * Use np to simplify the releasing process
f2prateek
added a commit
to segment-integrations/analytics.js-integration-segmentio
that referenced
this pull request
Jun 13, 2019
This updates a variety of tooling we use to build and releaase the library, such as: * Update to circle ci v2 as v1 is deprecated * Use commitlint and commitizen to maintain clean commit history * Update Karma configuration so we can use it with codecov to report coverage (see segmentio/analytics.js-core#75 for notes on implementation) * Use np to simplify the releasing process
f2prateek
added a commit
to segment-integrations/analytics.js-integration-segmentio
that referenced
this pull request
Jun 13, 2019
This updates a variety of tooling we use to build and releaase the library, such as: * Update to circle ci v2 as v1 is deprecated * Use commitlint and commitizen to maintain clean commit history * Update Karma configuration so we can use it with codecov to report coverage (see segmentio/analytics.js-core#75 for notes on implementation) * Use np to simplify the releasing process
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new karma configuration that can generate coverage reports that are uploaded to codecov.io.
For some reason, Safari and IE tests fail 100% of the time when code coverage is enabled (likely due to the browserify-istanbul plugin).
Rather than skip those browser or skip coverage entirely, I opted to make a new karma configuration that is exclusively used to report coverage results. This runs as a seperate job on CI and runs only on PhantomJS.