This repository was archived by the owner on Sep 3, 2022. It is now read-only.
Migrate to Circle CI 2.0 #77
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| version: 2 | ||
| jobs: | ||
| test: | ||
| docker: | ||
| - image: circleci/node:4-browsers | ||
| steps: | ||
| - checkout | ||
| - restore_cache: | ||
| key: dependency-cache-{{ checksum "package.json" }} | ||
|
There was a problem hiding this comment. we should probably switch to yarn here at some point. |
||
| - run: npm config set "//registry.npmjs.org/:_authToken" $NPM_AUTH | ||
| - run: make test | ||
| - save_cache: | ||
| key: dependency-cache-{{ checksum "package.json" }} | ||
| paths: | ||
| - node_modules | ||
| publish: | ||
| docker: | ||
| - image: circleci/node:4-browsers | ||
| steps: | ||
| - attach_workspace: { at: . } | ||
| - run: npm publish . | ||
| workflows: | ||
| version: 2 | ||
| test_and_publish: | ||
| jobs: | ||
| - test | ||
| - publish: | ||
| requires: | ||
| - test | ||
| filters: | ||
| tags: | ||
| only: /[0-9]+(\.[0-9]+)*(-.+)?/ | ||
|
There was a problem hiding this comment. @ccnixon @Peripheral1994 would love to get some on eyes on this part to ensure we're only deploying under two conditions (as before):
|
||
| branches: | ||
| only: master | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Node.js 4 has been dropped and 6 is in maintenance since April. We should consider upgrading to 8 (current LTS).
Node.js Release schedule
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes absolutely! I wanted to avoiding changing too much in this PR, but I think that's a great point. I'll make a ticket for this in the backlog.