Skip to content
This repository was archived by the owner on Sep 3, 2022. It is now read-only.

Conversation

fathyb
Copy link
Contributor

@fathyb fathyb commented Jun 21, 2018

Now that @segment/eslint-config@4.0.0 is published we can upgrade ESLint dependencies to get a warning free yarn install

package.json Outdated
"component-type": "^1.2.1",
"component-url": "^0.2.1",
"debug": "^0.7.4",
"eslint-plugin-react": "^7.9.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a dev dependency?

Copy link
Contributor Author

@fathyb fathyb Jun 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, fixing it

Copy link
Contributor

@f2prateek f2prateek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@f2prateek f2prateek merged commit 51ecb87 into segmentio:master Jun 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants