This repository was archived by the owner on Sep 3, 2022. It is now read-only.
Snyk #93
Merged
Snyk #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
=======================================
Coverage 98.58% 98.58%
=======================================
Files 11 11
Lines 636 636
=======================================
Hits 627 627
Misses 9 9Continue to review full report at Codecov.
|
fathyb
approved these changes
Jul 2, 2018
leifdreizler
reviewed
Jul 2, 2018
.circleci/config.yml
Outdated
| steps: | ||
| - checkout | ||
| - attach_workspace: { at: . } | ||
| - run: yarn run snyk test --severity-threshold=high --org=segment-pro |
There was a problem hiding this comment.
When using the snyk auth token that gets pulled in by context: snyk you shouldn't need to specify a --org. If you remove this and look at the tests you should still see Organisation: segment-pro in the snyk test and snyk monitor in CI.
Snyk monitors for vulnerable dependencies and notifies us if any were to be found. This fails the build if any high priority vulnerabilities are found in analytics.js-core. It runs as a seperate CI job to speed up builds. To reduce the copy paste between the different jobs, I moved the common bits into a defaults section that is shared between the jobs.
leifdreizler
approved these changes
Jul 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snyk monitors for vulnerable dependencies and notifies us if any were to be found.
This fails the build if any high priority vulnerabilities are found in analytics.js-core.
It runs as a seperate CI job to speed up builds. To reduce the copy paste between the different jobs, I moved the common bits into a defaults section that is shared between the jobs.