-
Notifications
You must be signed in to change notification settings - Fork 85
Replace robo with np for releasing. #96
Conversation
np is nice for a few things: * stricter checks (e.g. can't publish from a branch without forcing) * human readable version bumps (e.g. minor, major, patch) * supports distribution tags * public (doesn't require our private robofiles) * more user friendly UI The one disadvantage is that it publishes directly to NPM locally, so we'll need to use the `--no-publish` flag to avoid releasing from our local dev machines and have the CI do it instead (following https://github.com/sindresorhus/np#publish-with-a-ci). I added a helper script that has this flag set by default to make it easy to run as well.
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
=======================================
Coverage 98.58% 98.58%
=======================================
Files 11 11
Lines 636 636
=======================================
Hits 627 627
Misses 9 9 Continue to review full report at Codecov.
|
I think I'm opposed to this change. I fear |
I don't think we were using Here I'm replacing our local release steps using
I think robo (with < 500 stars) is likely to out of fashion before np (> 3k stars). |
I agree that having But I feel that using If analytics.js-core is going to be the only place where we use |
I disagree, np is a widely used tool for publishing npm packages. It's created by one of the top JS developers in the world - https://github.com/sindresorhus. He uses np to publish hundreds of his own packages. It's also the safest way to publish a package to npm, see https://github.com/sindresorhus/np#why. @f2prateek huge 👍 on this change! |
@ucarion I think the main goals here are to make releasing analytics.js-core simpler and safer (and not necessarily the full a.js process). I don't feel Specifically around the safety piece, np does the following that we don't get with NPM/Yarn out of the box and would have to wire up ourselves:
It doesn't feel like we're really coupling ourselves to We do already use |
Ok, sounds good. My objection was always a tepid one, and I think you've made a strong case for Consider me 👍 ! I've never made changes to this repo though, so I'll hold off on approving the PR. |
np is nice for a few things:
The one disadvantage is that it publishes directly to NPM locally, so we'll need to use the
--no-publish
flag to avoid releasing from our local dev machines and have the CI do it instead (following https://github.com/sindresorhus/np#publish-with-a-ci). I added a helper script that has this flag set by default to make it easy to run as well.