Skip to content

Fix/ie7 #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2014
Merged

Fix/ie7 #31

merged 2 commits into from
Oct 6, 2014

Conversation

yields
Copy link
Contributor

@yields yields commented Oct 6, 2014

it's a long story, * is dangerous :/

cc @calvinfo

@calvinfo
Copy link
Contributor

calvinfo commented Oct 6, 2014

sure, looks okay to me! what was the issue?

@yields
Copy link
Contributor Author

yields commented Oct 6, 2014

someone published component/assert@0.4.1, that depended on yields/fmt@0.0.2 that depended on JSON.

yields added a commit that referenced this pull request Oct 6, 2014
@yields yields merged commit 2ab06a9 into master Oct 6, 2014
@yields yields deleted the fix/ie7 branch October 6, 2014 22:12
@calvinfo
Copy link
Contributor

calvinfo commented Oct 6, 2014

yikes, nice find! do we use unpinned assert anywhere else? might be worth pinning it in the dev deps as well when we do ie testing

@yields
Copy link
Contributor Author

yields commented Oct 6, 2014

we use it only for tests now, but we don't test on ie7 yet, that's part of the problem i guess -- need to upgrade to the latest duo-test still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants