Skip to content

.ready: fix behavior when packages fail to load #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

.ready: fix behavior when packages fail to load #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/protos.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,8 @@ exports.locals = function(locals) {
* @api public
*/

exports.ready = function() {
exports.ready = function(err) {
if (err) return this.debug('error loading "%s" error="%s"', this.name, err);
this.emit('ready');
};

Expand Down
24 changes: 24 additions & 0 deletions test/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,4 +633,28 @@ describe('integration', function() {
assert(window.onload === onload);
});
});

describe('#ready', function() {
beforeEach(function() {
integration = new Integration();
});

it('should should emit a ready event', function() {
var called = false;
integration.on('ready', function() {
called = true;
});
integration.ready();
assert(called === true);
});

it('should should not emit a ready event if the integration fails', function() {
var called = false;
integration.on('ready', function() {
called = true;
});
integration.ready(new Error('failed to load'));
assert(called === false);
});
});
});