Removed nested objects from Braze identify and tracking calls #153
Conversation
| @@ -407,19 +408,23 @@ describe('Appboy', function() { | |||
| analytics.called(window.appboy.logCustomEvent, 'event'); | |||
| }); | |||
|
|
|||
| it('should send all properties', function() { | |||
| it('should send all properties except nested arrays and hashes', function() { | |||
There was a problem hiding this comment.
| it('should send all properties except nested arrays and hashes', function() { | |
| it('should send all properties except nested arrays and objects', function() { |
| @@ -335,10 +335,11 @@ describe('Appboy', function() { | |||
| ); | |||
| }); | |||
|
|
|||
| it('should handle custom traits of all types', function() { | |||
| it('should handle custom traits of acceptable types and excludes nested hashes', function() { | |||
There was a problem hiding this comment.
| it('should handle custom traits of acceptable types and excludes nested hashes', function() { | |
| it('should handle custom traits of acceptable types and excludes nested objects', function() { |
There was a problem hiding this comment.
arrays are not objects?
There was a problem hiding this comment.
typeof([])
"object"
There was a problem hiding this comment.
All looks good except some of the type checking conditionals. I'll be making it one of my priorities this week to start the release process with you guys. 😄
First, by releasing this PR to Segment's internal test sources and Braze's test sources. After we can confirm all is working in our production test sources, we'll begin rolling it out to the rest of our mutual customers.
Cheers!
GPS
|
Thanks @gpsamson let us know how we can help! |
|
One more thing @NikoRoberts. Can you bump the version to I'll start validating the changes on our end, but if you want to test them out yourself let me know and I can reach out to you via email. Thanks! GPS |
|
@gpsamson done |
…tio#153) * Removed nested objects from Braze identify and tracking calls * Apply suggestions from code review * bump braze integration version to v1.10.1 * Update integrations/appboy/lib/index.js
…tio#153) * Removed nested objects from Braze identify and tracking calls * Apply suggestions from code review * bump braze integration version to v1.10.1 * Update integrations/appboy/lib/index.js
What does this PR do?
Stops the plugin from erroring when analytics.track or identify calls are made with incompatible nested object data for Braze.
Are there breaking changes in this PR?
No
Any background context you want to provide?
This is related to Segment tech support ticket 353525
Is there parity with the server-side/android/iOS integration components (if applicable)?
Yes, at least iOS does similar sanitization before attempting to send data to Braze
https://github.com/segmentio/analytics.js-integrations/blob/master/integrations/appboy/lib/index.js#L256
Does this require a new integration setting? If so, please explain how the new setting works
No
Links to helpful docs and other external resources
Segment's own docs cover several times that nested data is not accepted by Braze in these calls.
https://segment.com/docs/destinations/braze/#identify