Fix xid changing when navigating subdomains. #469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljackins
requested review from
juliofarah,
williamgrosset,
bsneed,
dk1027 and
fathyb
bsneed
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes the segmentio integration to check the current domain for pre-existing xids as well, as subdomains cannot check localstorage or the httpOnly cookies that are being set (previously it would only check other xid domains for the xid)
Are there breaking changes in this PR?
No
Any background context you want to provide?
Customers were having an issue with their users xids changing when navigating to a subdomain rather than a different domain.
Is there parity with the server-side/android/iOS integration components (if applicable)?
N/A
Links to helpful docs and other external resources
https://segment.atlassian.net/browse/CC-6393