[MAIN] [STRATCONN-2841] Added event_id in page action of Pinterest Tag #801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnkitSegment
requested review from
varadarajan-tw,
Innovative-GauravKochar and
harsh-joshi99
| name: page.name() || '' | ||
| }; | ||
|
|
||
| var eventKeys = ['event_id', 'eid', 'eventID']; |
There was a problem hiding this comment.
Why do we search for eid, eventID these specific attributes? How did we decide these three values?
There was a problem hiding this comment.
There was a problem hiding this comment.
Okay. So, do we expect customers to provide these values in properties? Is this consistent with how we can handle track? Should we add supprot for eid, eventID in track as well?
There was a problem hiding this comment.
Yes, for track events, mappings are generated through the generatePropertiesObject function. Using forLoop, when the user adds any of these three event IDs, that value directly gets attached to the mappings.
varadarajan-tw
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
JIRA TICKET: https://segment.atlassian.net/browse/STRATCONN-2841
Create mapping for Pinterest event_id as segment messageId.
mapMessageIdToEventIdis disabled/falsemapMessageIdToEventIdis enabled/trueAre there breaking changes in this PR?
Testing
Any background context you want to provide?
Is there parity with the server-side/android/iOS integration components (if applicable)?
Does this require a new integration setting? If so, please explain how the new setting works
Links to helpful docs and other external resources