Skip to content
This repository was archived by the owner on Apr 28, 2022. It is now read-only.

fallback to localstorage #441

Merged
merged 2 commits into from
Mar 6, 2015
Merged

fallback to localstorage #441

merged 2 commits into from
Mar 6, 2015

Conversation

yields
Copy link
Contributor

@yields yields commented Mar 6, 2015

ianstormtaylor
ianstormtaylor reviewed Mar 6, 2015
View reviewed changes
lib/entity.js
}

// fallback to localstorage.
this._storage = store;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can local storage ever be unavailable? And should we fallback to just generating a new anonymousId every time in that case with another temp store (or similar)?

@ianstormtaylor
Copy link
Contributor

👍

yields added a commit that referenced this pull request Mar 6, 2015
@yields
Merge pull request #441 from segmentio/fallback
29443b0 
fallback to localstorage
@yields yields merged commit 29443b0 into master Mar 6, 2015
@yields yields deleted the fallback branch March 6, 2015 17:09
@yields
Copy link
Contributor Author

yields commented Mar 6, 2015

me and @ianstormtaylor discussed fallback to temp store a bit and we decided that we should deploy without it, if the environment doesn't have both localStorage and cookies we should check why first.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yields @ianstormtaylor