upgrading the segment-source-resource with google ads compatible segm… #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psankaranarayana
requested review from
maggieyu-segment,
ynguyensegment and
sangeetass
ynguyensegment
previously approved these changes
Mar 30, 2022
|
|
||
| def configure(levelname, **global_values): | ||
| try: | ||
| level = structlog.stdlib.INFO |
There was a problem hiding this comment.
Using logging is nice but curious why we need this change?
There was a problem hiding this comment.
this was deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/segmentio/python-source/pull/14
upgrading to use google ads compatible segment-source dependent package 0.17.1
Testing
Tested successfully from workbench for the following workspace https://app.segment.com/segment-engineering/sources/google_ads_29_cs_blr/overview