Update position as number #1059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eunjae-lee
requested review from
benhorowitz,
danielstjules and
n2parko
as code owners
|
Hi @eunjae-lee ! Thanks for the PR, I apologize for the lag as I was on PTO. This looks good to me, approved! |
sanscontext
approved these changes
Aug 24, 2020
|
@sanscontext no worries at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Hello everyone!
I'm Eunjae Lee working for Algolia.
Here's a glitch I'd like to fix.
positionneeds to be number on Algolia side, and the doc says it's a string.Not sure if the variable name
hitPositionOnIndexsuits your convention, or whatnot.Let me know if you want me to change it to something else.
Merge timing