Dev Center: Updates with security snippet #1078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanscontext
reviewed
Aug 28, 2020
|
I mostly don't touch legalese unless I have to. :) One edit which was originally to catch a typo, but it could use a touch of clarification. Aside from that, generally bullet points that are entire sentences should have a period at the end of them. |
|
Possible launch Tuesday Sept 8. |
eccoolidge
reviewed
Sep 8, 2020
src/partners/index.md
Outdated
| 5. Publish documentation. | ||
| 6. Submit your App for review. | ||
| 7. Launch into _Public Beta_! | ||
| 2. Review Segment's security guidance. |
There was a problem hiding this comment.
Hey @misteryeo - a tweak here might amp their responsibility as developers; consider changing "Review Segment's Security Guidance" to "Follow Segment's Security Guidance." That way, it more actively gets them doing what we want, as it goes beyond reading and head nodding. Well, only if it works. :)
Co-authored-by: LRubin <sanscontext@users.noreply.github.com>
sanscontext
approved these changes
Sep 9, 2020
…docs into security-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a request from the Security and Legal teams - no ticket available as it was communicated through email. Will share with respective teams for review before merging. No urgency here but please feel free to do a review in the meantime, Laura!