Extra properties #1188
Merged
Extra properties #1188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for segment-docs-preview ready! Built with commit f59b47f https://deploy-preview-1188--segment-docs-preview.netlify.app |
markzegarelli
approved these changes
Oct 28, 2020
| @@ -154,7 +154,7 @@ The list below outlines the properties included in the events listed above. | |||
| | `step` | The checkout step | Integer | | |||
| | `paymentMethod` | The payment method chosen for checkout | String | | |||
| | `shipping_method` | The shipping method chosen for checkout | String | | |||
| | context.Google Analytics.clientId | Th user's Google Analytics Client ID | String | | |||
| | context.Google Analytics.clientId | The user's Google Analytics Client ID | String | | |||
There was a problem hiding this comment.
@edwardupton Can you verify the property names here and on the next line? I'm confused by the space between Google and Analytics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Synced the functionality with the latest Littledata source, as documented here: https://blog.littledata.io/help/posts/segment-to-shopify-how-it-works/
Merge timing