Clarify replay behavior #1376
Merged
Clarify replay behavior #1376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current wording makes it seem like you can apply source-level changes and have them work with replayed data, and this is not true. This PR is a partner to #1375
markzegarelli
requested review from
markzegarelli
and removed request for
sanscontext
|
Deploy preview for segment-docs-preview ready! Built with commit e39c324 https://deploy-preview-1376--segment-docs-preview.netlify.app |
markzegarelli
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The current wording makes it seem like you can apply source-level changes and have them work with replayed data, and this is not true. This PR is a partner to #1375
Merge timing
Related issues
#1375