-
Notifications
You must be signed in to change notification settings - Fork 381
Update index.md #1407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update index.md #1407
Conversation
Deploy preview for segment-docs-preview ready! Built with commit 22610c5 https://deploy-preview-1407--segment-docs-preview.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@James9446 Just one clarification needed.
|
||
If `action_source` = 'website' then the `context.userAgent` and the `context.page.url` fields are required. Segment server-side libraries do not automatically collect the `context.userAgent` or the `context.page.url`. This data will need to be manually grabbed from the client and passed to the server. | ||
|
||
Example of a [`Product Added`](/docs/connections/spec/ecommerce/v2/#product-added) event using Node.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@James9446 What is the significance of the snippet below? Showing the relevant properties within the Context object?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markzegarelli yes, that is correct. The idea was to demonstrate an example of implementing the required parameters. Do you think there is a better or clearer approach? I would certainly be open to any suggestions to make sure this is clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@James9446 Cool, makes sense. I think it will be helpful to add a sentence that explains which props the reader should notice. For example: "Notice the in the example of a a Product Added event below".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great advice thanks! I'll make that update now.
Added clarification for the Implementing Server Event Parameter Requirements section
Proposed changes
Merge timing
ASAP after review