Skip to content

Conversation

kdaswani
Copy link
Contributor

@kdaswani kdaswani commented Apr 9, 2021

This support was added last year after we discovered Adobe requires 1s playheads. Fox has implemented this as per the language above and confirmed it works. You can see this in the integration: https://github.com/segmentio/analytics.js-integrations/blob/master/integrations/adobe-analytics/lib/index.js#L138 and https://github.com/segmentio/analytics.js-integrations/blob/master/integrations/adobe-analytics/lib/index.js#L1253.

This support was added last year after we discovered Adobe requires 1s playheads. Fox has implemented this as per the language above and confirmed it works. You can see this in the integration: https://github.com/segmentio/analytics.js-integrations/blob/master/integrations/adobe-analytics/lib/index.js#L138 and https://github.com/segmentio/analytics.js-integrations/blob/master/integrations/adobe-analytics/lib/index.js#L1253.
@kdaswani kdaswani requested a review from markzegarelli April 9, 2021 21:59
@netlify
Copy link

netlify bot commented Apr 9, 2021

Deploy preview for segment-docs ready!

Built with commit 5b34af8

https://deploy-preview-1510--segment-docs.netlify.app

Copy link
Contributor

@sanscontext sanscontext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sanscontext sanscontext merged commit 602dc83 into master Apr 12, 2021
@sanscontext sanscontext deleted the kdaswani-patch-2 branch April 12, 2021 17:45

## Set Up Steps for Web

The Adobe Heartbeat JS SDK is automatically included with the Segment-Adobe-Analytics integration when you add a Heartbeat Tracking Server URL.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kdaswani Can you explain this a bit more? Is the only thing someone implementing this needs to do is add the Heartbeat Tracking Server URL?

If you can just write it here in a comment, I'm taking a copyedit pass through the doc right now and can add.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markzegarelli yes this hasn't changed, we were just never clear on what "turns on" Adobe Heartbeat. You can see here in the integration code that we will load the Adobe Heartbeat SDK (which is different than the normal Adobe Analytics SDK) only if the customer has inputted a Heartbeat Tracking Server URL in the Destination Settings in the Segment UI: https://github.com/segmentio/analytics.js-integrations/blob/master/integrations/adobe-analytics/lib/index.js#L142. I think this is pretty clear as is in the docs? Do you want me to add more info?

We say something similar for iOS since the same holds true. Only Android requires manual steps to make sure the Heartbeat SDK is included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants