Skip to content

fix destination categories, and improve slugify #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 28, 2019
Merged

fix destination categories, and improve slugify #153

merged 3 commits into from
Oct 28, 2019

Conversation

XavierAgostini
Copy link
Contributor

Proposed changes

  • fixes destination catalog generation
  • improves slugify function to catch special characters in slug, i.e '&', '.', '(', ')'

Related issues (optional)

JIRA: https://segment.atlassian.net/browse/ACQ-2281

@XavierAgostini XavierAgostini merged commit 4ce1035 into master Oct 28, 2019
@XavierAgostini XavierAgostini deleted the ACQ-2281-slug-fixes branch October 28, 2019 21:57
bot-docsteam added a commit that referenced this pull request Dec 1, 2021
@bot-docsteam
Merge pull request #153 from segmentio/repo-sync
61a4e77 
repo sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@danielstjules danielstjules danielstjules approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XavierAgostini @danielstjules