Skip to content

Update date. #1565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 3, 2021
Merged

Update date. #1565

merged 3 commits into from
May 3, 2021

Conversation

misteryeo
Copy link
Contributor

Merge as soon as possible. Related to this ticket: https://segment.atlassian.net/secure/RapidBoard.jspa?rapidView=387&projectKey=PLATC&modal=detail&selectedIssue=PLATC-128

Simple date change because we're not ready for Branch to make updates just yet.

@misteryeo misteryeo requested a review from sanscontext May 3, 2021 20:38
Copy link
Contributor

@markzegarelli markzegarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@misteryeo I propose we remove any mention of future dates. We open ourselves up to customer disappointment if we don't hit a date (which appears to have happened already), and we generally don't document the future.

@netlify
Copy link

netlify bot commented May 3, 2021

Deploy preview for segment-docs ready!

Built with commit d162c92

https://deploy-preview-1565--segment-docs.netlify.app

Updated based on Mark's suggestion.
@misteryeo
Copy link
Contributor Author

@markzegarelli Sounds good - made changes :)

@markzegarelli markzegarelli merged commit 0b873de into master May 3, 2021
@markzegarelli markzegarelli deleted the misteryeo-patch-1 branch May 3, 2021 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants