Skip to content

Remove Schema Defaults documentation #1572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 6, 2021
Merged

Conversation

stevevls
Copy link
Contributor

@stevevls stevevls commented May 5, 2021

Proposed changes

Schema Defaults was a beta feature that was partially rolled out and
is slated to be EOL-ed soon. We are removing the docs now so that
we no longer get requests from customers to activate this feature.

Merge timing

Upon Approval

Related issues (optional)

https://segment.atlassian.net/browse/PROT-2959

Schema Defaults was a beta feature that was partiall rolled out and
is slated to be EOL-ed soon.  We are removing the docs now so that
we no longer get requests from customers to activate this feature.

PROT-2959
@stevevls stevevls requested review from mgutten and sanscontext May 5, 2021 21:25
@markzegarelli markzegarelli removed the request for review from sanscontext May 5, 2021 21:30
@netlify
Copy link

netlify bot commented May 5, 2021

Deploy preview for segment-docs ready!

Built with commit 0b4237a

https://deploy-preview-1572--segment-docs.netlify.app

@markzegarelli
Copy link
Contributor

@stevevls LGTM. I reviewed this since Laura is out this week. Feel free to merge, or wait for Marshall's review.

@mgutten
Copy link
Contributor

mgutten commented May 5, 2021

@stevevls making sure we're getting all the pages here! There are actually quite a few I think just using the search function on docs - not a comprehensive list, running between meetings 😬

https://segment.com/docs/guides/filtering-data/#schema-defaults
https://segment.com/docs/protocols/schema/#schema-defaults

do we want to go down the rabbit hole to identify all the locations now...? or should we hold off any do it all as part of our EOL later?

@stevevls
Copy link
Contributor Author

stevevls commented May 5, 2021

🤦 I had the wrong scope set for my search. I believe that they're all cleaned up now.

@mgutten
Copy link
Contributor

mgutten commented May 6, 2021

LGTM! :shipit:

@markzegarelli markzegarelli merged commit b76c847 into master May 6, 2021
@markzegarelli markzegarelli deleted the svls/kill-schema-defaults branch May 6, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants