Skip to content

Add note about event tag data types.md #1594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 14, 2021
Merged

Add note about event tag data types.md #1594

merged 4 commits into from
May 14, 2021

Conversation

kdaswani
Copy link
Contributor

Proposed changes

  • Added a note about accepted data types for eventTags. We recently ran into an issue where most-all of Fox's data was being rejected to Optimizely Full Stack, but Event Delivery did not say why. After working with Optimizely support, they told us that eventTags cannot be arrays so we had to use a Destination Filter to strip any array properties out and that resolved the issue. This adds a note to let customers know this could be a possible reason for message rejections. See note in Optimizely docs here: https://docs.developers.optimizely.com/full-stack/docs/include-event-tags#section-implement-tags

Merge timing

  • ASAP once approved

kdaswani added 2 commits May 13, 2021 20:42
@kdaswani
Add note about event tag data types.md
3dbbb76
@kdaswani
Clarifies rejection.md
a06f41e 
Clarifies that the entire event will be rejected by Optimizely
@netlify
Copy link

netlify bot commented May 14, 2021

Deploy preview for segment-docs ready!

Built with commit 3dbbb76

https://deploy-preview-1594--segment-docs.netlify.app

@netlify
Copy link

netlify bot commented May 14, 2021

Deploy preview for segment-docs ready!

Built with commit a06f41e

https://deploy-preview-1594--segment-docs.netlify.app

@markzegarelli markzegarelli merged commit bc5b33a into master May 14, 2021
@markzegarelli markzegarelli deleted the kiara/add-data-type-note branch May 14, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanscontext sanscontext Awaiting requested review from sanscontext

1 more reviewer

@markzegarelli markzegarelli markzegarelli approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kdaswani @markzegarelli