Skip to content

DOC-202 #1647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 9, 2021
Merged

DOC-202 #1647

merged 4 commits into from
Jun 9, 2021

Conversation

stayseesong
Copy link
Contributor

Proposed changes

  • image link fix
  • Vimeo/Youtube plugins snippet update
  • format changes
  • Included a table for the Supported Events section for the Youtube article as the previous formatting with the bullets was a little weird and made it hard to read as the sub-bullets aren't rendered in a different style

@stayseesong stayseesong requested a review from markzegarelli June 7, 2021 23:33
@netlify
Copy link

netlify bot commented Jun 7, 2021 •
edited
Loading

✔️ Deploy Preview for segment-docs ready!

🔨 Explore the source changes: 43b30a4

🔍 Inspect the deploy log: https://app.netlify.com/sites/segment-docs/deploys/60c0f7d2e321d70008e2c7f4

😎 Browse the preview: https://deploy-preview-1647--segment-docs.netlify.app

@stayseesong stayseesong changed the title Vimeo/Youtube Plugins snippet update, image fix, and format changes DOC-202 Jun 8, 2021
markzegarelli
markzegarelli suggested changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@markzegarelli markzegarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I have a few comments, and I know several of them are not about things you added, but since you're in here editing anyway, it's a good opportunity for cleanup.

Please also run these files through Vale for some additional cleanup.

@stayseesong stayseesong requested a review from markzegarelli June 9, 2021 17:18
@markzegarelli
Copy link
Contributor

@stayseesong LGTM 🚢

@stayseesong stayseesong merged commit b45f66a into master Jun 9, 2021
@stayseesong stayseesong deleted the DOC-202 branch June 9, 2021 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@markzegarelli markzegarelli markzegarelli approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stayseesong @markzegarelli