Skip to content

Conversation

jenskene
Copy link
Contributor

Fix instructions on how to find Amplitude API Key and Secret Key

Proposed changes

  • Changed link so it goes to Amplitude workspace (seems it is not possible to deep link to a project if you don't know what the project is)
  • Updated instructions to tell user to select the Project

Merge timing

  • ASAP once approved

Fix instructions on how to find Amplitude API Key and Secret Key
@jenskene jenskene requested review from nielst and sanscontext June 23, 2021 23:49
@jenskene
Copy link
Contributor Author

Do we have a policy on whether external links - like the link to the Amplitude workspace - open in a new tab? Would be nice if it opened in a new tab!

@netlify
Copy link

netlify bot commented Jun 23, 2021

✔️ Deploy Preview for segment-docs ready!

🔨 Explore the source changes: 72ff35c

🔍 Inspect the deploy log: https://app.netlify.com/sites/segment-docs/deploys/60d3ebc34886830008a56ac0

😎 Browse the preview: https://deploy-preview-1685--segment-docs.netlify.app

@markzegarelli
Copy link
Contributor

markzegarelli commented Jun 24, 2021

Do we have a policy on whether external links - like the link to the Amplitude workspace - open in a new tab? Would be nice if it opened in a new tab!

@jenskene
No policy, but I agree that it would be great if external links opened in a new tab by default.

I just looked into it a bit, and by formatting the code as follows, the link will open in a new tab / window:

[Amplitude Workspace](https://analytics.amplitude.com){:target="_blank"}

I also updated the CSS to automatically add an external link icon to these links.

@markzegarelli markzegarelli merged commit 3137db3 into master Jun 24, 2021
@markzegarelli markzegarelli deleted the jenskene-patch-1 branch June 24, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants