functions: single event handlers are no longer necessary when batching #1734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for segment-docs ready! 🔨 Explore the source changes: 8221917 🔍 Inspect the deploy log: https://app.netlify.com/sites/segment-docs/deploys/60ee3d80690826000776710b 😎 Browse the preview: https://deploy-preview-1734--segment-docs.netlify.app |
markzegarelli
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
I removed a section from the functions doc that's no longer applicable. Previously we would require that customers write both a batch handler and single event handlers when batching, in case our system wasn't able to form a batch with more than one event.
This is no longer necessary. When batching, centrifuge will invoke the batch handler even if there's only one event in the batch (https://github.com/segmentio/centrifuge/pull/1803).
Merge timing
ASAP once approved.