Skip to content

Conversation

charholt
Copy link
Contributor

Proposed changes

  • added image file to Braze
    /src/catalog/cloud-apps/braze/images/braze-connection-warning.png

@charholt charholt requested a review from stayseesong August 10, 2021 20:20
@netlify
Copy link

netlify bot commented Aug 10, 2021

✔️ Deploy Preview for segment-docs ready!

🔨 Explore the source changes: d83153c

🔍 Inspect the deploy log: https://app.netlify.com/sites/segment-docs/deploys/611af5615db8b30007ab7066

😎 Browse the preview: https://deploy-preview-1788--segment-docs.netlify.app

@stayseesong
Copy link
Contributor

@charholt is there a reason why we wanted an image of the warning in the docs? Can I just write the image out and put it in our own docs "warning" format?

@charholt
Copy link
Contributor Author

@stayseesong No specific reason. I'm new on the Customer Success Eng team and didn't know that was an option! Braze just reached out and asked to add the warning sign as it is also on their website. Would you like me to reach out to ask if we can write it in out in own "warning" format?

@stayseesong
Copy link
Contributor

@charholt sure!

@markzegarelli
Copy link
Contributor

Hi @charholt! Thanks for submitting this. I agree with Stacy that we should use our in-house warning here (see reference).

A screenshot would be appropriate if we were trying to highlight a specific area of the Braze web app, but since the crux of this screenshot is text, it will be better to add as text.

@stayseesong, when you have a chance, can you add the warning alert with the verbiage from Braze. Please also edit so it matches our writing style more closely.

@stayseesong stayseesong merged commit 4361695 into master Aug 17, 2021
@stayseesong stayseesong deleted the add_Braze_warning_image branch August 17, 2021 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants