Skip to content

create stub for missing catalog entries, and create report for missin… #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2019

Conversation

XavierAgostini
Copy link
Contributor

@XavierAgostini XavierAgostini commented Nov 1, 2019

Proposed changes

  • creates stub file for missing catalog docs
  • creates a record of the missing docs to complete: src/_data/catalog/incompleteDocs.yml

Related issues (optional)

JIRA: https://segment.atlassian.net/browse/ACQ-2290

@sanscontext
Copy link
Contributor

Looks good. Can I request one change? Can we add either “Source” or “Destination” at the end of the title depending on which it is? (We’re currently doing some liquid contortions in the template to programmatically add this and I’d rather we not. :) )

@XavierAgostini
Copy link
Contributor Author

Added that. But you would need to update the existing files to add that value

@XavierAgostini XavierAgostini merged commit 5563854 into master Nov 1, 2019
@XavierAgostini XavierAgostini deleted the ACQ-2290-create-stub-files branch November 1, 2019 17:59
@sanscontext
Copy link
Contributor

@XavierAgostini yeah, Irina and I have been adding them in site-docs the last few days. :) Thanks!

bot-docsteam added a commit that referenced this pull request Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants