Skip to content

Conversation

forstisabella
Copy link
Contributor

Proposed changes

Added section to the existing AWS S3 with IAM Role Support Destination page that covers creating an IAM role using the AWS CLI.

Merge timing

On or before Thursday, November 18th

Related issues (optional)

@forstisabella forstisabella added the fixed-content fix to content that has outdated or wrong information label Nov 16, 2021
@forstisabella forstisabella requested a review from a team as a code owner November 16, 2021 20:16
@forstisabella forstisabella requested review from markzegarelli and removed request for a team November 16, 2021 20:16
Copy link
Contributor

@markzegarelli markzegarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@forstisabella A few small changes. Also, the numbering is broken due to the code samples. You'll need to add two indents to all those. For example:

1. Copy the following code snippet and save it as a file on your local machine titled `trust-relationship-policy.json`. Replace `<YOUR_WORKSPACE_ID>` with your Segment workspace ID. 

    ```json
    {
      "Version": "2012-10-17",
      "Statement": [
        {
          "Sid": "",
          "Effect": "Allow",
          "Principal": {
            "AWS": "arn:aws:iam::595280932656:role/segment-s3-integration-production-access"
          },
          "Action": "sts:AssumeRole",
          "Condition": {
            "StringEquals": {
              "sts:ExternalId": "<YOUR_WORKSPACE_ID>"
            }
          }
        }
      ]
    }
    ```

@netlify
Copy link

netlify bot commented Nov 17, 2021

✔️ Deploy Preview for segment-docs ready!

🔨 Explore the source changes: 2085a66

🔍 Inspect the deploy log: https://app.netlify.com/sites/segment-docs/deploys/619546d858afde00081e32d6

😎 Browse the preview: https://deploy-preview-2150--segment-docs.netlify.app

@forstisabella forstisabella merged commit be4f272 into develop Nov 18, 2021
@forstisabella forstisabella deleted the s3-role-creation branch November 18, 2021 16:51
@github-actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed-content fix to content that has outdated or wrong information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants