Skip to content

fix(): Change input to button #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2019
Merged

fix(): Change input to button #239

merged 1 commit into from
Nov 18, 2019

Conversation

bart-krakowski
Copy link
Contributor

@bart-krakowski bart-krakowski commented Nov 15, 2019 •
edited by jedrzejchalubek
Loading

I changed input type="submit" to button, because button is expected tag to mark submit elements. In addition, the button does not need the type = "submit" attribute - this is the default behavior and input tag change our styles created for button.

Fixes #243

@jedrzejchalubek jedrzejchalubek mentioned this pull request Nov 18, 2019
Closed
XavierAgostini
XavierAgostini approved these changes Nov 18, 2019
View reviewed changes
Copy link
Contributor

@XavierAgostini XavierAgostini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@XavierAgostini XavierAgostini merged commit 0557295 into master Nov 18, 2019
@jedrzejchalubek jedrzejchalubek deleted the change-input-to-button branch November 20, 2019 09:04
bot-docsteam added a commit that referenced this pull request Feb 28, 2022
@bot-docsteam
Merge pull request #239 from segmentio/repo-sync
efbcb02 
repo sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@XavierAgostini XavierAgostini XavierAgostini approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Styling issue in "Request a demo" module
3 participants
@bart-krakowski @XavierAgostini @bart-tonik