remove salesforce DMP from salesforce list #2457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdaswani
requested review from
forstisabella and
markzegarelli
and removed request for
a team
|
@kdaswani Should we just unpublish this completely? |
|
Good question! Let's keep it unindexed for now just in case Fox still needs to reference it. In my JIRA to eventually deprecate, I've added a note to make sure we unpublish upon deprecation: https://segment.atlassian.net/browse/STRATCONN-1151. Thank you! |
markzegarelli
approved these changes
Feb 3, 2022
|
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
markzegarelli
added
the
back-end
markzegarelli
pushed a commit
that referenced
this pull request
Feb 4, 2022
* Updating limited access banner * [netlify-build] * complete after examples * complete before examples * format fix [netlify-build] * remove salesforce DMP from salesforce list (#2457) * remove salesforce DMP from salesforce list * Remove from strat for cleanliness Co-authored-by: markzegarelli <mark.zegarelli@segment.com> * Fix URLs in Regional Segment support table Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com> Co-authored-by: Wenxi Zeng <wenxi.zeng@segment.com> Co-authored-by: stayseesong <STACY.S.SONG@GMAIL.COM> Co-authored-by: Segment Docs Robot <73141528+bot-docsteam@users.noreply.github.com> Co-authored-by: stayseesong <83784848+stayseesong@users.noreply.github.com> Co-authored-by: kdaswani <49517136+kdaswani@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Salesforce DMP is in private beta, and was built 4+ years ago for Fox specifically. No customers should be using this destination, and StratConn is investigating deprecating it. In the meantime, I would like to remove it from the Salesforce nav in our docs, so customers cannot find the doc. It is already hidden but is still appear in the left-hand column:
I think this is because the strat = salesforce. If there's another reason it is still appearing, please update this PR to remove that. I don't see it when I'm searching so I think it is unindexed already.
Merge timing
Related issues (optional)