Skip to content

Adding language + fixing numbered list. #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2019
Merged

Adding language + fixing numbered list. #272

merged 1 commit into from
Nov 21, 2019

Conversation

misteryeo
Copy link
Contributor

Proposed changes

Adding onto Noah's changes - noticed there were some errors in the numbered list. Also needed to add some clarifying language for partners who will likely run into App name conflicts when creating an App.

sanscontext
sanscontext approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@sanscontext sanscontext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
FWIW, Markdown doesn't need the numbers to be consecutive to be rendered correctly. You could have a OL that starts only with 1. all the way down and markdown would handle it.

@sanscontext sanscontext merged commit f14ad5f into master Nov 21, 2019
@sanscontext sanscontext deleted the misteryeo-patch-1 branch November 21, 2019 22:48
bot-docsteam added a commit that referenced this pull request Mar 18, 2022
@bot-docsteam
Merge pull request #272 from segmentio/repo-sync
5538894 
repo sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@sanscontext sanscontext sanscontext approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@misteryeo @sanscontext