Skip to content

Integration foot fix #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 23, 2019
Merged

Integration foot fix #312

merged 5 commits into from
Nov 23, 2019

Conversation

sanscontext
Copy link
Contributor

@sanscontext sanscontext commented Nov 23, 2019 •
edited
Loading

add logic to handle edge cases where we:

  • don't have any matching catalog data at all
  • don't have connection-modes data
  • have a connection-modes table in the file already (as specified by it having "rewrite: true" in the frontmatter)

Plus working through some renames I found during this process.

@sanscontext sanscontext merged commit e2f0659 into master Nov 23, 2019
@sanscontext sanscontext deleted the integration-foot-fix branch November 23, 2019 00:45
bot-docsteam added a commit that referenced this pull request Apr 12, 2022
@bot-docsteam
Merge pull request #312 from segmentio/repo-sync
314efa0 
repo sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierAgostini XavierAgostini Awaiting requested review from XavierAgostini

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanscontext @bart-tonik