Update copy in Google Tag Manager article

[vanand17]

Proposed changes

Changing a letter from upper case to lower case based on how the event shows up in the destination.

Merge timing

[kdaswani]

@vanand17 Have we confirmed this with a live test? I actually don't see anywhere in the code where we send "Loaded a Page" so want to make sure this is actually all true. https://github.com/segmentio/analytics.js-integrations/blob/master/integrations/google-tag-manager/lib/index.js

Probably happens somewhere else but would love 100% confirmation from a true test if possible. We should also probably update the setting description to lowercase "a" in partner portal as well if so: https://app.segment.com/partner-portal/integration/google-tag-manager/settings

[kdaswani]

@vanand17 following up on my last comment before we merge this in.

Have we confirmed this with a live test? I actually don't see anywhere in the code where we send "Loaded a Page" so want to make sure this is actually all true. https://github.com/segmentio/analytics.js-integrations/blob/master/integrations/google-tag-manager/lib/index.js

Probably happens somewhere else but would love 100% confirmation from a true test if possible. We should also probably update the setting description to lowercase "a" in partner portal as well if so: https://app.segment.com/partner-portal/integration/google-tag-manager/settings

[vanand17]

Hi Kiara, I saw this request being approved hence I did not go ahead and run a test myself. Just to probably clarify, the change that was requested by a customer was around a spelling error which is currently reading 'Loaded A Page' and this could be changed to 'Loaded a Page' which a lower case 'a'. Attaching a screenshot below for your reference. [image: image.png] [image: image.png] Link to the sections of our docs - https://segment.com/docs/connections/destinations/catalog/google-tag-manager/#tracking-all-pages https://segment.com/docs/connections/destinations/catalog/google-tag-manager/#settings Apologies if this was not clear, please let me know if you need any further clarification :)

…

On Wed, Aug 24, 2022 at 2:55 AM kdaswani ***@***.***> wrote: @vanand17 <https://urldefense.com/v3/__https://github.com/vanand17__;!!NCc8flgU!a6xeJ4SnflVYRuh32ThkOvB1r20W3I9zaS8GDea_KPxk3WrnAiZSUmwJOoC_buDj3To5vQ_13cOc8ayRkWKFKw$> following up on my last comment before we merge this in. Have we confirmed this with a live test? I actually don't see anywhere in the code where we send "Loaded a Page" so want to make sure this is actually all true. https://github.com/segmentio/analytics.js-integrations/blob/master/integrations/google-tag-manager/lib/index.js <https://urldefense.com/v3/__https://github.com/segmentio/analytics.js-integrations/blob/master/integrations/google-tag-manager/lib/index.js__;!!NCc8flgU!a6xeJ4SnflVYRuh32ThkOvB1r20W3I9zaS8GDea_KPxk3WrnAiZSUmwJOoC_buDj3To5vQ_13cOc8axkFIks0Q$> Probably happens somewhere else but would love 100% confirmation from a true test if possible. We should also probably update the setting description to lowercase "a" in partner portal as well if so: https://app.segment.com/partner-portal/integration/google-tag-manager/settings — Reply to this email directly, view it on GitHub <https://urldefense.com/v3/__https://github.com/segmentio/segment-docs/pull/3331*issuecomment-1224344804__;Iw!!NCc8flgU!a6xeJ4SnflVYRuh32ThkOvB1r20W3I9zaS8GDea_KPxk3WrnAiZSUmwJOoC_buDj3To5vQ_13cOc8az4xnQakw$>, or unsubscribe <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AW7QVYI7ZNM6SBG3VAICGCDV2T7BHANCNFSM55Q2IXGA__;!!NCc8flgU!a6xeJ4SnflVYRuh32ThkOvB1r20W3I9zaS8GDea_KPxk3WrnAiZSUmwJOoC_buDj3To5vQ_13cOc8axClZJiSQ$> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[kdaswani]

Hi @vanand17 - thanks! I ran a test myself to be 100% sure that is what we send. I see that upon a page call, if tracking all pages, we see "Loaded a Page" in the GTM data layer. Approving this PR given my test. I will update the setting description in partner portal to also lowercase the "a" to match

.

[vanand17]

Thanks Kiara.

…

On Thu, Aug 25, 2022 at 3:27 AM kdaswani ***@***.***> wrote: ***@***.**** approved this pull request. — Reply to this email directly, view it on GitHub <https://urldefense.com/v3/__https://github.com/segmentio/segment-docs/pull/3331*pullrequestreview-1084243201__;Iw!!NCc8flgU!d8MfFA49TW4ClFu4yxvhvKJXHUpZaldrUxeekf5CS2j17uANmBnXPw7dER4RGha6g3NEESN6YGAjblNyYYtbPQ$>, or unsubscribe <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AW7QVYMIT2AL75PYYRCBC7DV2ZLQDANCNFSM55Q2IXGA__;!!NCc8flgU!d8MfFA49TW4ClFu4yxvhvKJXHUpZaldrUxeekf5CS2j17uANmBnXPw7dER4RGha6g3NEESN6YGAjblOMSbj8ew$> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[github-actions]

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.